Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enterprise_project_id to cce_cluster, rds, obs, sfs_file #593

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

Jason-Zhang9309
Copy link
Collaborator

@Jason-Zhang9309 Jason-Zhang9309 commented Oct 19, 2020

make testacc TEST='./huaweicloud' TESTARGS='-run TestAccCCEClusterV3_withEpsId'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccCCEClusterV3_withEpsId -timeout 360m
=== RUN TestAccCCEClusterV3_withEpsId
--- PASS: TestAccCCEClusterV3_withEpsId (414.48s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud 414.526s


make testacc TEST='./huaweicloud' TESTARGS='-run TestAccRdsInstanceV3_withEpsId'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccRdsInstanceV3_withEpsId -timeout 360m
=== RUN TestAccRdsInstanceV3_withEpsId
--- PASS: TestAccRdsInstanceV3_withEpsId (571.88s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud 571.927s


make testacc TEST='./huaweicloud' TESTARGS='-run TestAccObsBucket_withEpsId'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccObsBucket_withEpsId -timeout 360m
=== RUN TestAccObsBucket_withEpsId
--- PASS: TestAccObsBucket_withEpsId (16.38s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud 16.421s


make testacc TEST='./huaweicloud' TESTARGS='-run TestAccSFSFileSystemV2_withEpsId'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccSFSFileSystemV2_withEpsId -timeout 360m
=== RUN TestAccSFSFileSystemV2_withEpsId
--- PASS: TestAccSFSFileSystemV2_withEpsId (34.84s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud 34.891s

Related to #435

@@ -254,6 +254,8 @@ The `noncurrent_version_transition` object supports the following
* `days` (Required) Specifies the number of days when noncurrent object versions are automatically transitioned to the specified storage class.
* `storage_class` - (Required) The class of storage used to store the object. Only `WARM` and `COLD` are supported.

* `enterprise_project_id` - (Optional) The enterprise project id of the OBS. Changing this creates a OBS.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/OBS/OBS bucket/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creates a new OBS bucket

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

primary_dns = "100.125.1.250"
secondary_dns = "100.125.21.250"
vpc_id = huaweicloud_vpc_v1.test.id
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be replaced with testAccCCEClusterV3_Base(rName) as L232

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@niuzhenguo niuzhenguo merged commit b9fb182 into huaweicloud:master Oct 21, 2020
@Jason-Zhang9309 Jason-Zhang9309 deleted the dev-eps-id branch October 26, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants